I am making a React app that allows you to make a list and save it, but React has been giving me a warning that my elements don't have a unique key prop (elements List/ListForm). How should I create a unique key prop for user created elements? Below is my React code
var TitleForm = React.createClass({handleSubmit: function(e) {e.preventDefault();var listName = {'name':this.refs.listName.value};this.props.handleCreate(listName);this.refs.listName.value = "";},render: function() {return (<div><form onSubmit={this.handleSubmit}><input className='form-control list-input' type='text' ref='listName' placeholder="List Name"/><br/><button className="btn btn-primary" type="submit">Create</button></form></div>);}});var ListForm = React.createClass({getInitialState: function() {return {items:[{'name':'item1'}],itemCount:1};},handleSubmit: function(e) {e.preventDefault();var list = {'name': this.props.name, 'data':[]};var items = this.state.items;for (var i = 1; i < items.length; i++) {list.data.push(this.refs[items[i].name]);}this.props.update(list);$('#'+this.props.name).remove();}, handleClick: function() {this.setState({items: this.state.items.concat({'name':'item'+this.state.itemCount+1}),itemCount: this.state.itemCount+1});},handleDelete: function() {this.setState({itemCount: this.state.itemCount-1});},render: function() {var listItems = this.state.items.map(function(item) {return (<div><input type="text" className="list-form" placeholder="List Item" ref={item.name}/><br/></div>);});return (<div><form onSubmit={this.handleSubmit} className="well list-form-container">{listItems}<br/><div onClick={this.handleClick} className="btn btn-primary list-button">Add</div><div onClick={this.handleDelete} className="btn btn-primary list-button">Delete</div><button type="submit" className="btn btn-primary list-button">Save</button></form></div>)}});var List = React.createClass({getInitialState: function() {return {lists:[], savedLists: []};},handleCreate: function(listName) {this.setState({lists: this.state.lists.concat(listName)});},updateSaved: function(list) {this.setState({savedLists: this.state.savedLists.concat(list)});},render: function() {var lst = this;var lists = this.state.lists.map(function(list) {return(<div><div key={list.name} id={list.name}><h2 key={"header"+list.name}>{list.name}</h2><ListForm update={lst.updateSaved} name={list.name}/></div></div>)});var savedLists = this.state.savedLists.map(function(list) {var list_data = list.data;list_data.map(function(data) {return (<li>{data}</li>)});return(<div><h2>{list.name}</h2><ul>{list_data}</ul></div>)});var save_msg;if(savedLists.length == 0){save_msg = 'No Saved Lists';}else{save_msg = 'Saved Lists';}return (<div><TitleForm handleCreate={this.handleCreate} />{lists}<h2>{save_msg}</h2>{savedLists}</div>)}});ReactDOM.render(<List/>,document.getElementById('app'));
My HTML:
<div class="container"><h1>Title</h1><div id="app" class="center"></div></div>
Best Answer
There are many ways in which you can create unique keys
, the simplest method is to use the index when iterating arrays.
Example
var lists = this.state.lists.map(function(list, index) {return(<div key={index}><div key={list.name} id={list.name}><h2 key={"header"+list.name}>{list.name}</h2><ListForm update={lst.updateSaved} name={list.name}/></div></div>)});
Wherever you're looping over data, here this.state.lists.map
, you can pass second parameter function(list, index)
to the callback as well and that will be its index
value and it will be unique for all the items in the array.
And then you can use it like
<div key={index}>
You can do the same here as well
var savedLists = this.state.savedLists.map(function(list, index) {var list_data = list.data;list_data.map(function(data, index) {return (<li key={index}>{data}</li>)});return(<div key={index}><h2>{list.name}</h2><ul>{list_data}</ul></div>)});
Edit
However, as pointed by the user Martin Dawson in the comment below, this is not always ideal.
So what's the solution then?
Many
- You can create a function to generate unique keys/ids/numbers/strings and use that
- You can make use of existing npm packages like uuid, uniqid, etc
- You can also generate random number like
new Date().getTime();
and prefix it with something from the item you're iterating to guarantee its uniqueness - Lastly, I recommend using the unique ID you get from the database, If you get it.
Example:
const generateKey = (pre) => {return `${ pre }_${ new Date().getTime() }`;}const savedLists = this.state.savedLists.map( list => {const list_data = list.data.map( data => <li key={ generateKey(data) }>{ data }</li> );return(<div key={ generateKey(list.name) }><h2>{ list.name }</h2><ul>{ list_data }</ul></div>)});
It is important to remember that React expects STABLE keys, meaning you should assign the keys once and every item on your list should receive the same key every time, that way React can optimize around your data changes when it is reconciling the virtual DOM and decides which components need to re-render.So, if you are using UUID you need to do it at the data level, not at the UI level.
Also keep in mind you can use any string you want for the key, so you can often combine several fields into one unique ID, something like ${username}_${timestamp}
can be a fine unique key for a line in a chat, for example.
Keys helps React identify which items have changed/added/removed and should be given to the elements inside the array to give the elements a stable identity.
With that in mind, there are basically three different strategies as described bellow:
- Static Elements (when you don't need to keep html state (focus, cursor position, etc)
- Editable and sortable elements
- Editable but not sortable elements
As React Documentation explains, we need to give stable identity to the elements and because of that, carefully choose the strategy that best suits your needs:
STATIC ELEMENTS
As we can see also in React Documentation, is not recommended the use of index for keys "if the order of items may change. This can negatively impact performance and may cause issues with component state".
In case of static elements like tables, lists, etc, I recommend using a tool called shortid.
1) Install the package using NPM/YARN:
npm install shortid --save
2) Import in the class file you want to use it:
import shortid from 'shortid';
2) The command to generate a new id is shortid.generate().
3) Example:
renderDropdownItems = (): React.ReactNode => {const { data, isDisabled } = this.props;const { selectedValue } = this.state;const dropdownItems: Array<React.ReactNode> = [];if (data) {data.forEach(item => {dropdownItems.push(<option value={item.value} key={shortid.generate()}>{item.text}</option>);});}return (<selectvalue={selectedValue}onChange={this.onSelectedItemChanged}disabled={isDisabled}>{dropdownItems}</select>);};
IMPORTANT: As React Virtual DOM relies on the key, with shortid every time the element is re-rendered a new key will be created and the element will loose it's html state like focus or cursor position. Consider this when deciding how the key will be generated as the strategy above can be useful only when you are building elements that won't have their values changed like lists or read only fields.
EDITABLE (sortable) FIELDS
If the element is sortable and you have a unique ID of the item, combine it with some extra string (in case you need to have the same information twice in a page). This is the most recommended scenario.
Example:
renderDropdownItems = (): React.ReactNode => {const elementKey:string = 'ddownitem_'; const { data, isDisabled } = this.props;const { selectedValue } = this.state;const dropdownItems: Array<React.ReactNode> = [];if (data) {data.forEach(item => {dropdownItems.push(<option value={item.value} key={${elementKey}${item.id}}>{item.text}</option>);});}return (<selectvalue={selectedValue}onChange={this.onSelectedItemChanged}disabled={isDisabled}>{dropdownItems}</select>);};
EDITABLE (non sortable) FIELDS (e.g. INPUT ELEMENTS)
As a last resort, for editable (but non sortable) fields like input, you can use some the index with some starting text as element key cannot be duplicated.
Example:
renderDropdownItems = (): React.ReactNode => {const elementKey:string = 'ddownitem_'; const { data, isDisabled } = this.props;const { selectedValue } = this.state;const dropdownItems: Array<React.ReactNode> = [];if (data) {data.forEach((item:any index:number) => {dropdownItems.push(<option value={item.value} key={${elementKey}${index}}>{item.text}</option>);});}return (<selectvalue={selectedValue}onChange={this.onSelectedItemChanged}disabled={isDisabled}>{dropdownItems}</select>);};
Hope this helps.
Do not use this return `${ pre }_${ new Date().getTime()}`;
. It's better to have the array index instead of that because, even though it's not ideal, that way you will at least get some consistency among the list components, with the new Date function you will get constant inconsistency. That means every new iteration of the function will lead to a new truly unique key.
The unique key doesn't mean that it needs to be globally unique, it means that it needs to be unique in the context of the component, so it doesn't run useless re-renders all the time. You won't feel the problem associated with new Date initially, but you will feel it, for example, if you need to get back to the already rendered list and React starts getting all confused because it doesn't know which component changed and which didn't, resulting in memory leaks, because, you guessed it, according to your Date key, every component changed.
Now to my answer. Let's say you are rendering a list of YouTube videos. Use the video id (arqTu9Ay4Ig) as a unique ID. That way, if that ID doesn't change, the component will stay the same, but if it does, React will recognize that it's a new Video and change it accordingly.
It doesn't have to be that strict, the little more relaxed variant is to use the title, like Erez Hochman already pointed out, or a combination of the attributes of the component (title plus category), so you can tell React to check if they have changed or not.
edited some unimportant stuff
Let React Assign Keys To Children
You may leverage React.Children API:
const { Children } = React;const DATA = ['foo','bar','baz',];const MyComponent = () => (<div>{Children.toArray(DATA.map(data => <p>{data}</p>))}</div>);ReactDOM.render(<MyComponent />,document.getElementById("root"));
<div id="root"></div><script src="https://cdnjs.cloudflare.com/ajax/libs/react/16.6.3/umd/react.production.min.js"></script><script src="https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.6.3/umd/react-dom.production.min.js"></script>
To add the latest solution for 2021...
I found that the project nanoid provides unique string ids that can be used as key while also being fast and very small.
After installing using npm install nanoid
, use as follows:
import { nanoid } from 'nanoid';// Have the id associated with the data.const todos = [{id: nanoid(), text: 'first todo'}];// Then later, it can be rendered using a stable id as the key.const todoItems = todos.map((todo) =><li key={todo.id}>{todo.text}</li>)
Another option is weak-key: https://www.npmjs.com/package/weak-key
import weakKey from "weak-key";const obj1 = {a : 42};const obj2 = {b : 123};const obj3 = {a : 42};console.log(weakKey(obj1)); // 'weak-key-1'console.log(weakKey(obj2)); // 'weak-key-2'console.log(weakKey(obj3)); // 'weak-key-3'console.log(weakKey(obj1)); // 'weak-key-1'
Nowadays (2023) you can use crypto.randomUUID() to generate a UID. This can be used as a proper key. It's supported on all mainstream modern browsers and server-side JS platforms such as node. You should only have issues with this if you need to support IE11 or less.
See this for support details
For a simple array of text-strings; I'm trying one of the two ways:
1. encodeURI
which is available on both; NodeJS and browser
const WithEncoder = () => {const getKey = useCallback((str, idx) => encodeURI(`${str},${idx}`), [])return (<div>{["foo", "bar"].map((str, idx) => (<div key={getKey(str, idx)}>{str}</div>))}</div>)}
2. window.btoa
which is available only in browser.
const WithB2A = () => {const getKey = useCallback((str, idx) => window.btoa(`${str}-${idx}`), [])return (<div>{["foo", "bar"].map((str, idx) => (<div key={getKey(str, idx)}>{str}</div>))}</div>)}
Depends on the situation, choose a uniqueId creator is ok when you just want render silly items, but if you render items like drag&drop etc and you haven't any uniqueId for each item, I recommend remap that data in your redux, mapper, wherever and add for each item an uniqueId (and not in the render like <Item key={...}) because React couldn't perform any check between renders (and with that all the benefits).
With that remapped that you can use that new Id in your Component.
Here is what I have done, it works for reordering, adding, editing and deleting. Once set the key is not changed, so no unnecessary re-render. One PROBLEM which may be a show stopper for some: it requires adding a property to your object at first render say "_reactKey".
Example for functional component in psuedo TS (ie it won't run in snippets):
interface IRow{myData: string,_reactKey?:number}export default function List(props: {rows: Array<IRow>}) {const {myRows} = props;const [nextKey, setNextKey] = useState(100);const [rows, setRows] = useState<Array<IRow>|undefined>();useEffect(function () {if (myRows) {for (let row of myRows){if (!row._reactKey){row._reactKey = nextKey;setNextKey(nextKey+1);}}setRows(myRows);} else if (!rows) {setRows([]);}}, [myRows, columns]);addRow(){let newRow = { blah, blah, _reactKey : nextKey};setNextKey(nextKey+1);rows.push(newRow);setRows({...rows});}function MyRow(props:{row:IRow}){const {row} = props;return <tr><td>{row._reactKey}</td><td>row.myData</td></tr>}return <table><tr><th>Index</th><th>React Key</th><th>My Data</th></tr>rows.map((row, key)=>{return <MyRow key={row._reactKey} row={row} />}</table>}
I don't use react too much, but the last time I saw this issue I just created a new state array, and tracked the keys there.
const [keys, setKeys] = useState([0]);const [items, setItems] = useState([value: "", key: 0,])
Then when I add a new item to list, I get the last key from the keys array, add 1, then use setKeys to update the keys array. Something like this:
const addItemWithKey = () => {// create a new array from the state variablelet newKeyArr = [...keys];// create a new array from the state variable that needs to be tracked with keyslet newItemArr = [...items];// get the last key value and add 1let key = newKeyArr[newKeyArr.length-1] + 1;newKeyArr.push(key);newItemArr.push({value: "", key: key,});// set the state variable setKeys(newKeyArr);setItems(newItemArr);};
I don't worry about removing values from the keys array because it's only being used for iterating in the component, and we're trying to solve for the case where we remove an item from the list and/or add a new item. By getting the last number from the keys array and adding one, we should always have unique keys.
In the event that your data does not contain a unique ID (i.e. a database ID), you need to create a unique ID at the data level before the UI logic, so that the ID is stable. Generating ID's inside the key attribute are unstable, they cause React to destroy/create that element on every render because you are telling the ID itself to be changed on every render - React sees the key is different by comparison.
This is how you might amend the data within a component to have a simple stable numerical ID - it would be more efficient to amend the data further/as far up the component tree as possible. Using useRef to hold a persistent value, which is incremented each time a new ID is required, and useMemo to store the resulting amended data which will persist so long as the data it is based off does not change.
If you require the ID to be globally unique across the application i.e. if there is logic elsewhere utilizing the ID, then an external UUID generating package should be used. For simple lists where you just require a stable, unique ID, then an incrementing numeral value will suffice.
function Component(props) {const { data } = props;const idRef = useRef(-1);function getId() {idRef.current += 1;return idRef.current;}const dataAmended = useMemo(() => {return data.map((item) => {return { ...item, id: getId() };});}, [data]);const listItems = dataAmended.map((item) => {return <li key={item.id}>{item.title}</li>;});return <ul>{listItems}</ul>;}
import React, {useState} from 'react';import {SafeAreaView,ScrollView,StyleSheet,Text,View,Dimensions} from 'react-native';const {width}=Dimensions.get('window');function sayfalar(){let pages=[]for (let i = 0; i < 100; i++) { pages.push(<View key={i} style={styles.pages}><Text>{i}</Text></View>)}return pages}const App=()=>{return(<View style={styles.container}><ScrollView horizontal={true} pagingEnabled={true}>{sayfalar()}</ScrollView></View>)}const styles = StyleSheet.create({container:{flexDirection:'row',flex:1},pages:{width:width}})export default App;
You can use react-html-id to generate uniq id easely : https://www.npmjs.com/package/react-html-id
Use a time key
const timeKey = (pre) => {return `${ pre }_${ new Date().getTime() }`;}const savedLists = this.state.savedLists.map( list => {const list_data = list.data.map( data => <li key={ timeKey(data) }>{ data }</li> );return(<div key={ timeKey(list.name) }><h2>{ list.name }</h2><ul>{ list_data }</ul></div>)});
Hope this helps.
The fastest solution in 2021 is to use uniqid: Go to https://www.npmjs.com/package/uniqid for more info but to sum up:
- First in your terminal and your project file: npm install uniqid
- Import uniqid in your project
- Use it in any key that you need!
uniqid = require('uniqid');return(<div><div key={ uniqid() } id={list.name}><h2 key={ uniqid() }>{list.name}</h2><ListForm update={lst.updateSaved} name={list.name}/></div></div>)});
I am using this:
<div key={+new Date() + Math.random()}>